[Webkit-unassigned] [Bug 26375] VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp

Tue Jun 23 22:57:07 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=26375

eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31531|review?                     |review+
               Flag|                            |

------- Comment #16 from eric at webkit.org  2009-06-23 22:57 PDT -------
(From update of attachment 31531)
Wow!  Thank you for the awesome investigation.

Unfortunately the current patch doesn't seem to actually have the code change,
just a comment?

This is the only log message you need in the ChangeLog:
WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that
cannot be represented in the current code page (932). Save the file in Unicode
format to prevent data loss

The rest of the build output you can remove from the ChangeLog.

r- for lack of code change.  Otherwise I'd r+ this.  Thanks again for the
investigation!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.