[Webkit-unassigned] [Bug 26375] VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26375





------- Comment #15 from tyoshino at google.com  2009-06-22 21:12 PDT -------
(In reply to comment #14)
> What happens if we "Save the file in Unicode format"?  Does it just add a UTF8
> BOM to the top of the file?
> 

I couldn't find what the message "Save the file in Unicode format" in C4819
(http://msdn.microsoft.com/en-us/library/ms173715.aspx) exactly means. However,
Visual Studio 2005 Professional has a "Advanced Save Options" for its editor. I
saw five encoding options in the dialog with "Unicode" in them.

So, I've tested building WebKit by saving WebCoreLocalizedString.cpp with each
of them. Whether a BOM is added or not is also described.

Build mode used: Release (because run-safari in debug mode on Windows fails too
frequently)
Check: Navigate to some image
(http://www.google.co.jp/intl/ja_jp/images/logo.gif) and check the title

Save mode: Unicode (UTF-8 with signature) - Codepage 65001
The source was encoded by UTF-8 w/ BOM
Build: Successful
Result: localized string not found

Save mode: Unicode - Codepage 1200
The source was encoded by UTF-16 Little Endian w/o BOM
Build: Successful
Result: localized string not found

Save mode: Unicode (Big-Endian) - Codepage 1201
The source was encoded by UTF-16 Big-Endian w/o BOM
Build: Successful
Result: localized string not found

Save mode: Unicode (UTF-7) - Codepage 65000
The source was encoded by UTF-7
Build: Failure
4>WebCoreLocalizedStrings.cpp
4>..\WebCoreLocalizedStrings.cpp(1) : error C2059: syntax error : '/'
4>..\WebCoreLocalizedStrings.cpp(7) : error C2059: syntax error : '+'
4>..\WebCoreLocalizedStrings.cpp(13) : error C2137: empty character constant
4>..\WebCoreLocalizedStrings.cpp(35) : error C2653: 'WebCore' : is not a class
or namespace name

Save mode: Unicode (UTF-8 without signature) - Codepage 65001
The source was encoded by UTF-8 w/o BOM
Build: Failure. We need to remove /Wx option (take warnings as errors)
Build w/o /Wx: Successful
Result: localized string not found

None of them fixed the problem. I saw "logo.gif 276~110 pixels image" on the
title bar only when I replace the character with escape sequences (\xC3\x97).

Thanks,


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.