[Webkit-unassigned] [Bug 26590] Support for String.trim(), String.trimLeft() and String.trimRight() methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26590





------- Comment #7 from darin at apple.com  2009-06-22 16:46 PDT -------
(In reply to comment #6)
> "Also, we frown on the use of mysterious booleans. I think an enum TrimLeft,
> TrimRight, TrimBothLeftAndRight would work better than two booleans anyway."
> 
> Actually this is my first attempt to contribute code to the WebKit engine and I
> don't know if my code violates coding conventions. if this is case I'll change
> code of course. these "mysterious booleans" are used in "trimString()" method
> that is used only internally by: trim(), trimLeft() and trimRight() methods and
> actually is not accessible from JavaScript.

Even inside the code, those booleans are unnecessarily vague, and an enum would
work better.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.