[Webkit-unassigned] [Bug 26590] Support for String.trim(), String.trimLeft() and String.trimRight() methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26590





------- Comment #6 from ioseb.dzmanashvili at gmail.com  2009-06-22 16:01 PDT -------
(In reply to comment #4)

Thank you for positive response Darin!

I've added more tests for all mentioned characters. 

"Also, we frown on the use of mysterious booleans. I think an enum TrimLeft,
TrimRight, TrimBothLeftAndRight would work better than two booleans anyway."

Actually this is my first attempt to contribute code to the WebKit engine and I
don't know if my code violates coding conventions.. if this is case I'll change
code of course... these "mysterious booleans" are used in "trimString()" method
that is used only internally by: trim(), trimLeft() and trimRight() methods and
actually is not accessible from JavaScript.




> Created an attachment (id=31687)
 --> (https://bugs.webkit.org/attachment.cgi?id=31687&action=view) [review]
> String.trim(), String.trimLeft(), String.trimRight() patch update
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.