[Webkit-unassigned] [Bug 26279] REGRESSION: typing in gmail pegs CPU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26279


ojan at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31582|                            |review?
               Flag|                            |




------- Comment #20 from ojan at chromium.org  2009-06-19 18:03 PDT -------
Created an attachment (id=31582)
 --> (https://bugs.webkit.org/attachment.cgi?id=31582&action=view)
WebCore:


2009-06-19  Ojan Vafai  <ojan at chromium.org>

        Reviewed by NOBODY (OOPS!).

        Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
        keyword values. When diff is called on a CSSStyleDeclaration, we check
        the keywordSize to see if font-size matches a keyword value.

        This ensures that when we diff a CSSMutableStyleDeclaration returned
from
        copyInheritableProperties on a CSSComputedStyleDeclaration that we
        correctly identify matching font-sizes.

        We should consider having copyInheritableProperties return something
        other than a CSSMutableStyleDeclaration though (e.g. a
        CSSMutableStyleDeclarationForEditing to ensure that this
        sort of font-size mismatch can't happen in the future.

        https://bugs.webkit.org/show_bug.cgi?id=26279

        Test: editing/inserting/font-size-clears-from-typing-style.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::cssPropertyMatches):
        * css/CSSComputedStyleDeclaration.h:
        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::cssPropertyMatches):
        (WebCore::CSSStyleDeclaration::diff):
        * css/CSSStyleDeclaration.h:

LayoutTests:

2009-06-19  Ojan Vafai  <ojan at chromium.org>

        Reviewed by NOBODY (OOPS!).

        This test hits an edge case where typingStyle would never get cleared.
        In addition to making every text insertion go into its own text node,
        this caused large performance problems.

        https://bugs.webkit.org/show_bug.cgi?id=26279

        * editing/inserting/font-size-clears-from-typing-style-expected.txt:
Added.
        * editing/inserting/font-size-clears-from-typing-style.html: Added.
        * editing/inserting/resources/TEMPLATE.html: Copied from
LayoutTests/editing/execCommand/resources/TEMPLATE.html.
        * editing/inserting/resources/font-size-clears-from-typing-style.js:
Added.
        (editable.onkeyup):
---
 10 files changed, 138 insertions(+), 2 deletions(-)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.