[Webkit-unassigned] [Bug 26103] [GTK] Remove gtk/cairo/pango/freetype/fontconfig includes from the header files in WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 17:48:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26103


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30814|review?                     |review+
               Flag|                            |




------- Comment #10 from eric at webkit.org  2009-06-18 17:48 PDT -------
(From update of attachment 30814)
This looks fine to me.  Why though?  I assume for compile performance?

This comment should reference the COMPILE_ASSERT:
+// This is in fact a cairo_glyph_t make sure this keeps matching

I don't really believe the numbers you posted.  The change was small (seconds).
 Did you run the numbers multiple times and confirm that your numbers are
consistent?

I'm really just gonna trust you on this one.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list