[Webkit-unassigned] [Bug 26103] [GTK] Remove gtk/cairo/pango/freetype/fontconfig includes from the header files in WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 01:53:16 PDT 2009


------- Comment #9 from bunk at stusta.de  2009-06-11 01:53 PDT -------
(In reply to comment #8)
> > Overally, my personal opinion is that your patch is going into the wrong
> > direction - even if my suspicion that it might also be wrong on some technical
> > details turns out to be wrong.
> Please elaborate on it. Do you disagree with forward declarations in general?
> for glib types? I know it is a bigger difference from C to C++. But forward
> declarations are a pretty common way to speed compilation up. We use it
> extensively in WebKit. Or in a more dramatic way... why do you think
> MediaQueryEvaluator.cpp needs to know about GIO?

The glib types and the changes leading to the COMPILE_ASSERT() are what I
dislike about your patch.

But I get your point, and especially due to the fact that something like
#include <glib/gtypes.h> (which might be the best way to get the glib types
without pulling in all glib headers) is strongly deprecated your patch might be
the way to go for speeding up the compilation.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list