[Webkit-unassigned] [Bug 25526] [Gtk] Additional support is needed for caret browsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25526


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29992|review?                     |review-
               Flag|                            |




------- Comment #19 from eric at webkit.org  2009-06-15 13:49 PDT -------
(From update of attachment 29992)
executeMoveParagraphBackward and executeMoveParagraphForward implementations
seem flipped.

What does Caret Browsing mean?

Seems this should be a static function:
bool caretBrowsing = frame->settings() &&
frame->settings()->caretBrowsingEnabled();

bool caretBrowsingEnabled(frame)

Seems this should be a nicely-named constant somewhere:
static_cast<EditorCommandSource>(0)

Or there should be a different version of enabledInEditableText which doesn't
take a source.

How does one test this?  We need at least a manual test if not a LayoutTest.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.