[Webkit-unassigned] [Bug 25526] [Gtk] Additional support is needed for caret browsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25526





------- Comment #20 from xan.lopez at gmail.com  2009-06-15 13:58 PDT -------
(In reply to comment #19)
> (From update of attachment 29992 [review])
> executeMoveParagraphBackward and executeMoveParagraphForward implementations
> seem flipped.

Yeah, silly me.

> 
> What does Caret Browsing mean?

It means the hability to browse web pages only using the keyboard, thanks to a
special mode in the browser called, you guessed, caret browsing mode. It's of
great importance for accessibility, and Gecko's implementation is specified
here: http://www.mozilla.org/access/keyboard/proposal

> 
> Seems this should be a static function:
> bool caretBrowsing = frame->settings() &&
> frame->settings()->caretBrowsingEnabled();
> 
> bool caretBrowsingEnabled(frame)

Sure.

> 
> Seems this should be a nicely-named constant somewhere:
> static_cast<EditorCommandSource>(0)
> 
> Or there should be a different version of enabledInEditableText which doesn't
> take a source.

I think at least for this patch keeping the dummy constant would be better, we
can further refactor it in follow-up patches.

> 
> How does one test this?  We need at least a manual test if not a LayoutTest.
> 

OK, I can provide at the very least a manual test.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.