[Webkit-unassigned] [Bug 26146] Change to use ThreadableLoader to load the worker script in order to check URL origin for redirection.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26146





------- Comment #3 from jianli at chromium.org  2009-06-03 15:07 PDT -------
(In reply to comment #2)
> (From update of attachment 30922 [review])
> I didn't full review this yet, but wanted to share some comments anyway.
> 
> > +        https://bugs.webkit.org/show_bug.cgi?id=26146
> > +        Test for the above bug.
> 
> Please add a title of the bug (or, better yet, what is fixed, because the bug's
> title mentions both the problem and a suggested approach, which may be
> confusing to some watchers).
I will add more details in next patch.
> 
> > +        * http/tests/workers/resources/redirect.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/redirect.php.
> 
> We have a copy in http/tests/resources (I think that we should remove the
> xmlhttprequest and other copies one day for consistency).
I will change to use that copy.
> 
> I don't understand why importScripts() uses WorkerScriptLoader - isn't it ok
> for these scripts to come from any domain, or via redirects?
> 
importScripts() uses WorkerImportScriptsClient, that has been renamed to
WorkerScriptLoader so that both normal script loading and importScript could
use the same functionaility.

Yes, currently there is a bug in redirect handling for importScripts. It should
allow script coming and redirecting from any origin. I will fix it in other
patch and also add a layout test for it next time.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.