[Webkit-unassigned] [Bug 26146] Change to use ThreadableLoader to load the worker script in order to check URL origin for redirection.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 3 14:57:36 PDT 2009


------- Comment #2 from ap at webkit.org  2009-06-03 14:57 PDT -------
(From update of attachment 30922)
I didn't full review this yet, but wanted to share some comments anyway.

> +        https://bugs.webkit.org/show_bug.cgi?id=26146
> +        Test for the above bug.

Please add a title of the bug (or, better yet, what is fixed, because the bug's
title mentions both the problem and a suggested approach, which may be
confusing to some watchers).

> +        * http/tests/workers/resources/redirect.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/redirect.php.

We have a copy in http/tests/resources (I think that we should remove the
xmlhttprequest and other copies one day for consistency).

I don't understand why importScripts() uses WorkerScriptLoader - isn't it ok
for these scripts to come from any domain, or via redirects?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list