[Webkit-unassigned] [Bug 26145] WebInspector halts when opening with debugger enabled globally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26145


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30909|review?                     |review+
               Flag|                            |




------- Comment #2 from timothy at hatcher.name  2009-06-03 09:37 PDT -------
(From update of attachment 30909)
> -            enableDebugger();
> +            m_frontend->attachDebuggerWhenShown();

Can't you just leave this calling enableDebugger() since you fixed that
function?

>          disableDebugger();
> +        m_attachDebuggerWhenShown = true;

Why is this needed? Shoudln't this be m_attachDebuggerWhenShown = false? If it
is supose to be false, should disableDebugger() set it to false? If it isn't
those things, maybe a comment is needed to explain.

> -        enableDebugger();
> +        m_attachDebuggerWhenShown = true;

Same as before. Can't you just leave this calling enableDebugger() since you
fixed that function?

> +            this._attachDebuggerWhenShown = false;

I like to use delete this._attachDebuggerWhenShown for cases like this, since
there is no benifit to keeping this property around.

r+, but maybe this can be a smaller change based on the comments above.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.