[Webkit-unassigned] [Bug 26145] WebInspector halts when opening with debugger enabled globally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26145


pfeldman at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30909|0                           |1
        is obsolete|                            |
  Attachment #30911|                            |review?
               Flag|                            |




------- Comment #3 from pfeldman at chromium.org  2009-06-03 10:08 PDT -------
Created an attachment (id=30911)
 --> (https://bugs.webkit.org/attachment.cgi?id=30911&action=view)
fix

(In reply to comment #2)
> (From update of attachment 30909 [review])
> > -            enableDebugger();
> > +            m_frontend->attachDebuggerWhenShown();
> 
> Can't you just leave this calling enableDebugger() since you fixed that
> function?
> 

Done

> >          disableDebugger();
> > +        m_attachDebuggerWhenShown = true;
> 
> Why is this needed? Shoudln't this be m_attachDebuggerWhenShown = false? If it
> is supose to be false, should disableDebugger() set it to false? If it isn't
> those things, maybe a comment is needed to explain.
> 
> > -        enableDebugger();
> > +        m_attachDebuggerWhenShown = true;
> 

I added a comment for this. The scenario is: close window when debugger is
enabled, expect it to be enabled when the window is being reopened. The hidden
thing is that debugger is being disabled on window close unconditionally.

> Same as before. Can't you just leave this calling enableDebugger() since you
> fixed that function?
> 

Done. It is just that I fixed the function after I changed these.

> > +            this._attachDebuggerWhenShown = false;
> 
> I like to use delete this._attachDebuggerWhenShown for cases like this, since
> there is no benifit to keeping this property around.
> 

Done.

> r+, but maybe this can be a smaller change based on the comments above.
> 

Thanks!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.