[Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27651





--- Comment #25 from Jakub Wieczorek <faw217 at gmail.com>  2009-07-30 05:57:59 PDT ---
(In reply to comment #24)
> (From update of attachment 33766 [details])
> r=me
> 
> +    if (plugin && !plugin->mimeToExtensions().contains(mimeType))
> 
> I would formulate this one the other way around:
> 
> if (!plugin || plugin->mimeToExtension().contains(mimeType))
>     return;
> 
> What do you think?

That was not the purpose. We want to set the plugin only if it supports the
given mime type or is null (because that will reset the setting).

Or did you mean:

if (!plugin || plugin->mimeToExtension().contains(mimeType))
    m_preferredPlugins.set(mimeType.lower(), plugin);

?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.