[Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27651


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33766|review?(hausmann at webkit.org |review+
               Flag|)                           |




--- Comment #24 from Simon Hausmann <hausmann at webkit.org>  2009-07-30 05:51:07 PDT ---
(From update of attachment 33766)
r=me

+    if (plugin && !plugin->mimeToExtensions().contains(mimeType))

I would formulate this one the other way around:

if (!plugin || plugin->mimeToExtension().contains(mimeType))
    return;

What do you think?

The rest looks good to me :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.