[Webkit-unassigned] [Bug 27119] bugzilla-tool: Add create-bug command

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 28 22:40:31 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27119


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33691|review?                     |review+
               Flag|                            |




--- Comment #22 from David Levin <levin at chromium.org>  2009-07-28 22:40:28 PDT ---
(From update of attachment 33691)

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +2009-07-28  David Kilzer  <ddkilzer at apple.com>
> +
> +        <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Implement "create-bug" command for bugzilla-tool.

oooo new format :)


> diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py

> +        if match:
> +            text_lines = BeautifulSoup(match.group('error_message')).findAll(text=True)
> +            error_message = "\n" + '\n'.join(["  " + line.strip() for line in text_lines if line.strip()])

fwiw, this statment is at the edge of the complexity boundary.  It is hard to
define but when you start seeing "for in if" + other stuff, you're close.

I'd leave it as is though.  Just something to keep in mind in your future
python writing sessions :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list