[Webkit-unassigned] [Bug 27424] adding GStringBinding.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27424





--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-20 09:22:57 PDT ---
(In reply to comment #3)
> (From update of attachment 33050 [details])
> This is using WebCore types, so the above header file is internal, this means
> you should follow the WebCore coding style guidelines, which you don't. The
> first issue i notice is the placement of the '*'.

 ack, got it.  also restyled the functions - hope that's what you meant.

> On the question of content, I wonder if the gdom/ directory is supposed to hold
> public API as well? 

 the files that are to be public api are copied out of there, to a location
 under INCLUDEDIR/gdom so that the #includes can have "gdom/" in them on
 public builds as well as internal ones.

 so, gdom.h is kept there, as are GdomDOMObject.h - all the rest are private
 and/or internal.

 it's a bit of a grey area to me to be honest and i'm surprised i managed
 to come up with something that doesn't make everything fall over [by
 accidentally referencing out-of-date headers]

 so it's all an area where i welcome input but equally i would be very
 relieved by a decision which recognised that this is all a bit iffy
 and that resolving it requires significant additional thought and
 probably extra code, and said "we'll leave this one for now, flag it
 as an issue under a separate bugreport / TODO".

> if that is the case you should put the GStringConvert
> somewhere else, and calling it GStringConvert is a bit misleading as GString !=
> gchar.

 ok renamed to gdom/ConvertToGCharPrivate.h to indicate that it's internal.


> please revise.

 done - what do you think?

 l.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.