[Webkit-unassigned] [Bug 27424] adding GStringBinding.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27424


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33050|review?                     |review-
               Flag|                            |




--- Comment #3 from Holger Freyther <zecke at selfish.org>  2009-07-19 22:55:25 PDT ---
(From update of attachment 33050)
This is using WebCore types, so the above header file is internal, this means
you should follow the WebCore coding style guidelines, which you don't. The
first issue i notice is the placement of the '*'.

On the question of content, I wonder if the gdom/ directory is supposed to hold
public API as well? if that is the case you should put the GStringConvert
somewhere else, and calling it GStringConvert is a bit misleading as GString !=
gchar.

please revise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.