[Webkit-unassigned] [Bug 27158] Add WebKit version API to Qt.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27158





--- Comment #17 from robert <robert at roberthogan.net>  2009-07-17 12:07:12 PDT ---
(In reply to comment #16)
> It just seems a whole lot easier for the ports to use if all they have to do is
> to include a header file, instead of calling scripts in their build system.
> 
> Mark, do you remember why the windows port uses a version text file and
> auto-generates the header file from it, in contracts to a regular header file?
> 

FWIW, the gtk port does the same as Windows. They have a webkitversion.h.in
which configure.ac populates from values manually updated (AFAICT) in
configure.ac.

Generating a version header file from the Version.xcconfig at build time would
avoid the need for this individual effort, and would avoid the need for any
additional manual intervention for version tracking. It would also mean that
the webkit version in the UA string would always mean the same thing for all
webkit ports.

Additionally, nothing fancy should be required to generate the header file in
other ports build systems, since it can just be added to the same list of calls
currently generating source from *.idl files at build.

> 
> One additional comment: I realize that if we take the version from
> WebKit/mac/Configurations/Version.xcconfig, then we should put the header file
> probably into WebKit/WebKitVersion.h, instead of taking the version from WebKit
> and creating a header file in WebCore.
> 
Yes, was conscious WebCore/ seemed a funny place to put it, but WebKit/ root
has no other source files in it at all - so it felt the lesser of two evils.

> 
> Robert, perhaps at this point the easiest would be to split up your patch into
> two parts:
> 
> 1) One that deals with WebKitVersion.h, and we can figure out among the ports
> how to best handle and generate it.
> 
> 2) The bigger part of your current patch that adds the API to the Qt Port, with
> the fallback. That also changes the user agent and its documentation.

NP. Will await a final direction on whether to go with the manual or
auto-generated WebKitVersion.h before submitting the first one. Also, can you
confirm that the root of WebKit/ is the right place to put it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.