[Webkit-unassigned] [Bug 27158] Add WebKit version API to Qt.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27158


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrowe at apple.com




--- Comment #16 from Simon Hausmann <hausmann at webkit.org>  2009-07-17 07:40:05 PDT ---
(In reply to comment #13)
> > 
> > I have a few small comments below. Otherwise I have only one suggestion:
> > Instead of generating the entire header file from within the .pro file simply
> > include the contents of the generated header file in your patch itself.
> 
> My intention was to remove the need for manual intervention.  I don't
> understand why keeping version updates manual is necessary, but happy to do
> what is required. I'll provide an updated patch on this basis.

It just seems a whole lot easier for the ports to use if all they have to do is
to include a header file, instead of calling scripts in their build system.

Mark, do you remember why the windows port uses a version text file and
auto-generates the header file from it, in contracts to a regular header file?

> > Out of curiousity, why did you decide to append the Safari bit at the end
> > instead of just keeping the existing
> > initual ua.append() line and use arg() twice?
> > 
> 
> To bring Qt's user agent string into line with the format adopted by other
> ports:
> 
> http://www.mattcutts.com/blog/google-chrome-user-agent/
> 
> http://209.85.229.132/search?q=cache:fd3ykESxOycJ:www.useragentstring.com/pages/Safari/+safari+user+agent&cd=3&hl=en&ct=clnk
> 
> http://gitorious.org/qtwebkit/qtwebkit/blobs/1a9740a524a3cc5958c996f945a99ddad144f3f4/WebKit/gtk/webkit/webkitwebsettings.cpp
> (line 182)

Ahh, I see. That's a good point :)


One additional comment: I realize that if we take the version from
WebKit/mac/Configurations/Version.xcconfig, then we should put the header file
probably into WebKit/WebKitVersion.h, instead of taking the version from WebKit
and creating a header file in WebCore.


Robert, perhaps at this point the easiest would be to split up your patch into
two parts:

1) One that deals with WebKitVersion.h, and we can figure out among the ports
how to best handle and generate it.

2) The bigger part of your current patch that adds the API to the Qt Port, with
the fallback. That also changes the user agent and its documentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.