[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32304|review?                     |review-
               Flag|                            |




--- Comment #12 from Oliver Hunt <oliver at apple.com>  2009-07-16 00:43:56 PDT ---
(From update of attachment 32304)
> +
> +void ScrollViewCanvasHaiku::Draw(BRect updateRect)
> +{
> +    FrameView* fv = static_cast<FrameView*>(m_scrollView);
> +    if (!fv || !fv->frame() || !fv->frame()->contentRenderer())
> +        return;
> +
> +    while (fv->needsLayout()) {
> +        fv->layout();
> +    }
Single line code block should not have braces :D

> +void ScrollViewCanvasHaiku::KeyDown(const char* bytes, int32 numBytes)
> +{
> +    BMessage* message = Looper()->CurrentMessage();
> +    if (!message)
> +        return;
> +
> +    WebCore::FrameView* fv = static_cast<WebCore::FrameView*>(m_scrollView);
> +    if (!fv || !fv->frame())
> +    	return;
> +
> +    if(!fv->frame()->eventHandler()->keyEvent(PlatformKeyboardEvent(message)))
> +    	printf("-->KeyDown: not arrived\n");    
> +
> +    if((int)bytes[0] != (int)B_TAB)
> +        BView::KeyDown(bytes, numBytes);

We use c++ casts for all casts in webkit -- eg. static_cast

> +}
> +
> +void ScrollViewCanvasHaiku::KeyUp(const char* bytes, int32 numBytes)
> +{
> +    BMessage* message = Looper()->CurrentMessage();
> +    if (!message)
> +        return;
> +
> +    WebCore::FrameView* fv = static_cast<WebCore::FrameView*>(m_scrollView);
> +    if (!fv || !fv->frame())
> +    	return;
> +
> +    if(fv->frame()->eventHandler()->keyEvent(PlatformKeyboardEvent(message)))
> +    	printf("-->KeyUp: not arrived\n"); 
> +
> +    if(bytes[0] != (int)B_TAB)
ditto

Basically looks fine except the aforementioned style issues

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.