[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32303|review?                     |review-
               Flag|                            |




--- Comment #11 from Oliver Hunt <oliver at apple.com>  2009-07-16 00:36:51 PDT ---
(From update of attachment 32303)
> +void Pasteboard::writeSelection(Range* selectedRange, bool canSmartCopyOrDelete, Frame* frame)
> +{
> +    BMessage* data;
> +
> +    if (be_clipboard->Lock()) {
> +        be_clipboard->Clear();
> +        if ((data = be_clipboard->Data())) {
> +            data->AddString("text/plain", BString(frame->selectedText()));
> +            be_clipboard->Commit();
> +        }
> +        be_clipboard->Unlock();
> +    }
> +}

You'll want a bug to track supporting pasting of rich text.  Also i'm concerned
about where be_clipboard comes from?  If it's the global pasteboard in haiku
you don't want to use it here

> +String Pasteboard::plainText(Frame* frame)
> +{
> +    BString string;
> +    BMessage* data;
> +
> +    if (be_clipboard->Lock()) {
> +        if ((data = be_clipboard->Data())) {
> +            data->FindString("text/plain", &string);
> +        }
No braces on a single line if statement

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.