[Webkit-unassigned] [Bug 27303] [WINCE] implement createThreadInternal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27303





--- Comment #3 from Yong Li <yong.li at torchmobile.com>  2009-07-15 09:48:08 PDT ---
(In reply to comment #2)
> (From update of attachment 32790 [details])
> > +#if !PLATFORM(WINCE)
> >  #include <process.h>
> > +#endif
> 
> For?

process.h doesn't exist on WINCE

> 
> > +#if HAVE(ERRNO_H)
> > +#include <errno.h>
> > +#else
> > +#define NO_ERRNO
> > +#endif
> 
> I'm not sure.  In a previous patch to RegisterFile we were using 'GetLastError'
> instead of errno for WINCE.  Shouldn't we do the same here?  Moreover, we
> should create a proper WTF abstraction for ERRNO it seems.

I'm not sure replacing ERRNO with GetLastError is good in all cases. In this
file, we can do that because the only case of using errno is after
CreateThread() fails.

> 
> > +#if PLATFORM(WINCE)
> > +    // This should be safe on WINCE.  On Windows desktop it is not.
> > +    HANDLE threadHandle = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)wtfThreadEntryPoint, invocation, 0, (LPDWORD)&threadIdentifier);
> 
> Why is it safe for WINCE, but not for desktop and what does it gain us?

No gain. we do this because with don't have _beginthreadex() on WINCE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.