[Webkit-unassigned] [Bug 27303] [WINCE] implement createThreadInternal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27303


Adam Treat <treat at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32790|review?                     |review-
               Flag|                            |




--- Comment #2 from Adam Treat <treat at kde.org>  2009-07-15 09:41:46 PDT ---
(From update of attachment 32790)
> +#if !PLATFORM(WINCE)
>  #include <process.h>
> +#endif

For?

> +#if HAVE(ERRNO_H)
> +#include <errno.h>
> +#else
> +#define NO_ERRNO
> +#endif

I'm not sure.  In a previous patch to RegisterFile we were using 'GetLastError'
instead of errno for WINCE.  Shouldn't we do the same here?  Moreover, we
should create a proper WTF abstraction for ERRNO it seems.

> +#if PLATFORM(WINCE)
> +    // This should be safe on WINCE.  On Windows desktop it is not.
> +    HANDLE threadHandle = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)wtfThreadEntryPoint, invocation, 0, (LPDWORD)&threadIdentifier);

Why is it safe for WINCE, but not for desktop and what does it gain us?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.