[Webkit-unassigned] [Bug 26457] Build DumpRenderTree under Cairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26457





------- Comment #15 from bfulgham at webkit.org  2009-07-02 16:27 PDT -------
(In reply to comment #14)
> (From update of attachment 32190 [review])
> There's a newer version of the license header in
> WebCore/html/PreloadScanner.cpp. Please use that template for new files.
> 
> > +        * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
> > +          common pringPNG function.
> 
> Typo: pringPNG

Fixed while landing.

> > +    printPNG (dataLength, data);
> 
> Please remove the space after "printPNG".

Fixed while landing. 

> > +typedef struct _cairo* CairoContextRef;
> 
> I thought there was a cairo_t typedef. Maybe there's some reason we can't use
> that name here.

No; I thought it would be nice to look more like the CG code for comparison,
but we use cairo_t* everywhere else, so I'm changing to that while landing.

> > +    BitmapContext(PlatformBitmapBuffer buffer, CairoContextRef context)
> > +        : m_buffer(buffer)
> > +        , m_context(context)
> > +    {
> > +    }
> > +
> > +    PlatformBitmapBuffer m_buffer;
> > +    CairoContextRef m_context;
> 
> Do we need to retain/release m_context (using the appropriate Cairo functions)?
> 
> r=me
Yes; I forgot about the possibility of the m_context not being null at the time
we do the Adopt.  So, it needs to release the old context (if it exists), but
it does *not* add a retain to the pointer being passed in.

Thanks -- I corrected that as well. 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.