[Webkit-unassigned] [Bug 26457] Build DumpRenderTree under Cairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26457


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32190|review?                     |review+
               Flag|                            |




------- Comment #14 from aroben at apple.com  2009-07-02 14:23 PDT -------
(From update of attachment 32190)
There's a newer version of the license header in
WebCore/html/PreloadScanner.cpp. Please use that template for new files.

> +        * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
> +          common pringPNG function.

Typo: pringPNG

> +    printPNG (dataLength, data);

Please remove the space after "printPNG".

> +typedef struct _cairo* CairoContextRef;

I thought there was a cairo_t typedef. Maybe there's some reason we can't use
that name here.

> +    BitmapContext(PlatformBitmapBuffer buffer, CairoContextRef context)
> +        : m_buffer(buffer)
> +        , m_context(context)
> +    {
> +    }
> +
> +    PlatformBitmapBuffer m_buffer;
> +    CairoContextRef m_context;

Do we need to retain/release m_context (using the appropriate Cairo functions)?

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.