[Webkit-unassigned] [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 21 16:45:24 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23435


estade at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26916|                            |review?
               Flag|                            |




------- Comment #12 from estade at chromium.org  2009-01-21 16:45 PDT -------
Created an attachment (id=26916)
 --> (https://bugs.webkit.org/attachment.cgi?id=26916&action=view)
try4

> We use "0" instead of "NULL" in WebKit.

Ok.

> But why does m_gradient have to be null? ...

OK, but I left the ASSERT to avoid future head-banging since the current use
pattern should never hit this ASSERT and it would only be hit if someone made
changes.

> Thanks for the nice work!

thanks for the review


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list