[Webkit-unassigned] [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23435


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26911|review?                     |review+
               Flag|                            |




------- Comment #11 from zimmermann at kde.org  2009-01-21 16:28 PDT -------
(From update of attachment 26911)
Patch looks much better, r+, with one comments:

> +        void setSpreadMethod(GradientSpreadMethod spreadMethod) {
> +            ASSERT(m_gradient == NULL);
> +            m_spreadMethod = spreadMethod;
> +        }

We use "0" instead of "NULL" in WebKit. But why does m_gradient have to be
null?
I'd rather implement the setSpreadMethod in Gradient.cpp, and add a FIXME to
handle
dynamic spread method changes (when m_gradient has already been created),
instead
of asserting

Thanks for the nice work!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.