[Webkit-unassigned] [Bug 23156] cant alignt text to the right using right shift and right ctrl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23156





------- Comment #6 from hbono at chromium.org  2009-01-07 22:32 PDT -------
> executeMakeTextDirectionLeftToRight() implements functionality that, as far as
> I know, does not exist in other engines, and a choice was made to implement it
> using the CSS properties 'unicode-bidi' and 'direction'. Why do you feel that
> executeMakeTextDirectionLeftToRight() needs to use DOM attributes, and how 
> does it relate to this bug?

Sorry again, I forgot describing it in this thread. (I'm mixed this thread and
another internal discussion.)

Maybe we are somewhat misunderstanding WebKit, however, we mapped a Right Ctrl
+ Right Shift key combination to this executeMakeTextDirectionLeftToRight()
function in our EditorClientImpl::handleKeyboardEvent() implementation but it
did not change the "dir" attribute and caused the original problem.
So, I assumed this function should change the "dir" attribute as I wrote in my
previous response.

If this mapping is wrong, is it possible to give us better mapping functions?
(To read the _changeBaseWritingDirectionTo, it seems to call the
Editor::setBaseWritingDirection() function. Nevertheless, I'm not sure I'm
correct.)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.