[Webkit-unassigned] [Bug 23156] cant alignt text to the right using right shift and right ctrl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23156





------- Comment #3 from mitz at webkit.org  2009-01-07 19:50 PDT -------
(In reply to comment #2)
> Sorry not to have describe its details.
> This bug technically consists of two bugs:

Then it would be much better to have two separate bugs in Bugzilla about it.

> 1. We need to change the Windows convention of CTRL+SHIFT keys, including
> adding methods to distinguish left keys and right keys;

Okay. Hopefully there is a higher-level way to describe the key combination for
changing the writing direction (maybe it is even user-configurable), but this
seems like a clear task: recognizing that the user has issued the command to
change the writing direction.

> 2. The WebCore::executeMakeTextDirectionLeftToRight() function (in
> EditorCommand.cpp) does not change the "dir" attribute of the selected node, as
> the Editor::setBaseWritingDirection() function does. It only changes its CSS
> attributes, such as "--webkit-direciton". So, the function causes a serious
> inconsistency between DOM attributes and CSS properties.

I think you are mixing up two separate concepts: the "text" or
"character-level" directionality and the "paragraph-level" or "base" writing
direction.

> To fix the second bug, we need to:
> (a) Change the WebCore::executeMakeTextDirectionLeftToRight() function to call
> the Editor::setBaseWritingDirection() function to change the writing direction,

No, setting the text direction of a range should not change the paragraph-level
writing direction.

> or;
> (b) Add code to the function to change the DOM attributes.

I do not think that would be necessary. setBaseWritingDirection has the
necessary code to achieve what the command does, in a way that as far as I can
tell is compatible with IE.

Perhaps some of your confusion stems from the fact that the character-level
commands have a modern implementation as editor commands, and the
paragraph-level commands have a lot of their logic (such as for validation and
state checking) still in WebKit (in WebHTMLView.mm). I think a good first step
could be to modernize the way the paragraph-level commands are implemented. I
think that will make the differences between the concepts clearer and make
addressing issue (1) easier.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.