[Webkit-unassigned] [Bug 23116] [GTK] fix random libsoup crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23116





------- Comment #4 from zecke at selfish.org  2009-01-07 08:37 PDT -------
(In reply to comment #3)
> Created an attachment (id=26488)
 --> (https://bugs.webkit.org/attachment.cgi?id=26488&action=view) [review]
> patch 1

We always use four (4) spaces. Your patch still has a style issue...


> Anyway, I'm cleaning up the patch, and here's the first and uncontroversial
> fix: keeping track of the idle source and removing it in the destructor.
> 
> For the second part the problem is more complex: It is not possible to remove
> the async callback (yes, this is a bug in the GIO API), so the data passed to
> the GIO callbacks must stay valid until this callback is called. The easiest
> method is to just ref the ResourceHandle, but that means Webkit has no control
> about the lifetime of the ResourceHandle. I'm going to prepare a patch for
> that.

This is backwards and will be ugly. You would need to know when the WebCore
side is detached from the ResourceHandle... and then never ever call into the
ResourceClient callbacks... It might be best to not use GIO for file/data at
all...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.