[Webkit-unassigned] [Bug 23116] [GTK] fix random libsoup crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23116


otte at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26429|0                           |1
        is obsolete|                            |
  Attachment #26488|                            |review?
               Flag|                            |




------- Comment #3 from otte at gnome.org  2009-01-07 02:42 PDT -------
Created an attachment (id=26488)
 --> (https://bugs.webkit.org/attachment.cgi?id=26488&action=view)
patch 1

Yay, looks like I stepped right into all newcomer traps at once.

Anyway, I'm cleaning up the patch, and here's the first and uncontroversial
fix: keeping track of the idle source and removing it in the destructor.

For the second part the problem is more complex: It is not possible to remove
the async callback (yes, this is a bug in the GIO API), so the data passed to
the GIO callbacks must stay valid until this callback is called. The easiest
method is to just ref the ResourceHandle, but that means Webkit has no control
about the lifetime of the ResourceHandle. I'm going to prepare a patch for
that.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.