[Webkit-unassigned] [Bug 24152] Move the logic to do the unconfirmed message count and pending activity setting from WorkerMessagingProxy to Worker.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24152





------- Comment #6 from jianli at chromium.org  2009-02-25 23:25 PDT -------
Fixed this issue by adding the check in Worker class.

I also fixed the occasional crash I talked to you this afternoon. The fix is to
change line "reportPendingActivity(true);" in
WorkerMessagingProxy::workerThreadCreated to
"m_workerObject->reportPendingActivity(false, true);". The reason for the
failure is that workerThreadCreated is executed in main thread and if we call
reportPendingActivity(true) it will post a task to the main thread and
unfortunately this task might get a chance to be performed at very late time
when the proxy goes away.

(In reply to comment #4)
> I don't under this:
>   Worker::hasPendingActivity() will return true even after the worker context
> has been terminated. Previously, it would return false after this.
> 
> Why is this change ok?  (Won't this cause GC issues?)
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.