[Webkit-unassigned] [Bug 23940] Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23940





------- Comment #5 from jchaffraix at webkit.org  2009-02-18 01:50 PDT -------
> > the only problematic
> > change I see is in DragController - the other changes are (X)HTML-specific.
> 
> I think DragController is fine, too -the results was casted to
> HTMLAnchorElement* anyway. I wonder if the cast can be avoided altogether by
> creating the element more directly.

Right, I have missed the cast. I will make this change too as a short-term
enhancement but I feel more and more that such manual creation are bad and will
backfire on us someday. We should have the Elements' factories exports a way to
create a "default" element using the static names.

> Let's change it back then - from my understanding of the code,
> "createdByParser" is tightly coupled to the parser behavior, which is unlikely
> to be followed here.

Ok.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.