[Webkit-unassigned] [Bug 23940] Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 17 11:33:23 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23940





------- Comment #4 from ap at webkit.org  2009-02-17 11:33 PDT -------
(In reply to comment #3)
> Yes, it is. We are creating a title tag for an HTML document (there is a
> "if(!HTMLDocument()) ... else" guard above). I can add a test case if you
> request it in light of my point.

My mistake. I don't think this needs a test case now.

> the only problematic
> change I see is in DragController - the other changes are (X)HTML-specific.

I think DragController is fine, too -the results was casted to
HTMLAnchorElement* anyway. I wonder if the cast can be avoided altogether by
creating the element more directly.

> This is called from the parser so I have though it was correct to set
> createdByParser to true. I have no strong feelings about the value given
> thought.

Let's change it back then - from my understanding of the code,
"createdByParser" is tightly coupled to the parser behavior, which is unlikely
to be followed here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list