[Webkit-unassigned] [Bug 23900] Prevent frames from calling themselves _top

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23900


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27568|review?                     |review-
               Flag|                            |




------- Comment #3 from ap at webkit.org  2009-02-17 02:58 PDT -------
(From update of attachment 27568)
+        WARNING: NO TEST CASES ADDED OR CHANGED

The fix looks reasonable, but it definitely needs an automated test case, r-
because of that. Note that I couldn't easily make Safari crash with the code
provided in bug 23899.

+       Make sure a frame does not name itself "_top".  This prevents a crash.

Please fix ChangeLog to use spaces, not tabs.

A better place for this line is in the generated part of ChangeLog:

+        * page/FrameTree.cpp:
+        (WebCore::FrameTree::uniqueChildName):


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.