[Webkit-unassigned] [Bug 23900] Prevent frames from calling themselves _top

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 17 11:54:39 PST 2009


------- Comment #4 from eric at webkit.org  2009-02-17 11:54 PDT -------
(From update of attachment 27568)
It seems we need a test case for _top, _parent, _blank, _self (and any other
special names).

If I were writing this code, I might even consider breaking this if out into a
static inline function.

if (isAllowedChildName(this, requestedName))
    return requestedName;

static isAllowedChildName(FrameTree* tree, const AtomicString& name)
if (name.isEmpty() || child(name))
    return false;

if (name == "_blank" || name == "_top" || name == "_parent" || name == "_self")
  return false;

return true;

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list