[Webkit-unassigned] [Bug 23766] CanvasRenderingContext2D::setShadow needs else for other platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 13:22:20 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23766


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27356|review?                     |review+
               Flag|                            |




------- Comment #3 from eric at webkit.org  2009-02-05 13:22 PDT -------
(From update of attachment 27356)
Yeah, this is an OK solution for platforms w/o CYMK support, but it would be
bad if used on platforms which did. I feel like this may need a FIXME to note
that this should use a smarter color class some day.  (We should be able to
pass a CYMK color along to graphics context directly w/o having to convert it
to RGB here.)  The patch looks fine though.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list