[Webkit-unassigned] [Bug 33065] Chromium Linux: add support for per-strike font render preferences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33065


Adam Langley <agl at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45682|0                           |1
        is obsolete|                            |




--- Comment #6 from Adam Langley <agl at chromium.org>  2009-12-30 14:20:28 PST ---
Created an attachment (id=45685)
 --> (https://bugs.webkit.org/attachment.cgi?id=45685)
patch v3: two sided so please don't cq+

> kNoPreference or some such
> 
> > +        m_style.useBitmaps = 2;

Done

> > +    void queryStyle();
> 
> Perhaps this could have a more verbose name that is more self-descriptive.

Done

> > +    FcPatternAdd(pattern, FC_FAMILY, fcvalue, 0);
> 
> The last param should be FcFalse for this and below.

Done

> > +    // Some versions of fontconfig don't actually write a value into result.
>
> Set result = OK at the start, check it at the end?

Not clear that it wouldn't break. fontconfig's own code does this so I'm going
to mirror it.


> > +    FcBool b;
> 
> One-letter variables make the reviewer man sad.

reviewer man is unnecessarily sad.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.