[Webkit-unassigned] [Bug 33065] Chromium Linux: add support for per-strike font render preferences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33065





--- Comment #5 from Evan Martin <evan at chromium.org>  2009-12-30 13:41:47 PST ---
(From update of attachment 45682)
> +    paint->setAntiAlias(m_style.useAntiAlias == 2 ? isSkiaAntiAlias : m_style.useAntiAlias);
> +    paint->setHinting(m_style.useHinting == 2 ? skiaHinting : (SkPaint::Hinting) m_style.hintStyle);

2 => kNoPreference or some such

> +        m_style.useBitmaps = 2;

Here too.

> +    void queryStyle();

Perhaps this could have a more verbose name that is more self-descriptive.

> +    FcPatternAdd(pattern, FC_FAMILY, fcvalue, 0);

The last param should be FcFalse for this and below.

> +    // Some versions of fontconfig don't actually write a value into result.

Set result = OK at the start, check it at the end?

> +    FcBool b;

One-letter variables make the reviewer man sad.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.