[Webkit-unassigned] [Bug 32826] [Qt] Delegation client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32826





--- Comment #6 from Luiz Agostini <luiz.agostini at openbossa.org>  2009-12-29 15:05:02 PST ---
The first idea was to put new methods in class QWebPageClient but after a talk
with you Kenneth I was convinced that it was not the place for it.

I did not use the cast because at the point where the methods are needed I just
have access to an instance of the abstract class HostWindow. I know it is
indeed an instance of chrome but using this information I would be throwing
away the HostWindow abstraction.

I think that chrome has a standard way to provide this kind of service through
the method platformPageClient of the HostWindow interface. Today
platformPageClient is returning an instance of the class QWebPageClient. The
proposal is to return an instance of a new class (QtPlatformPageClient) that
aggregates an instance of QWebPageClient and an instance of another new class
(QtDelegationClient) responsible for delegates. I believe that chrome would be
then providing the desired functionality in a standard way without messing with
QWebPageClient's scope or responsibilities.

This solution is Qt specific. Although the patch makes changes in several files
the changes are all very simple. QWebPageClient is still available and
QtDelegationClient can be used for combobox popups and for the delegates that
will come in future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.