[Webkit-unassigned] [Bug 32826] [Qt] Delegation client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32826





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-12-29 06:20:03 PST ---
I didn't like this change very much. It seems a bit the wrong way around. You
could have added a new delegate() method or so to our QWebPageClient, but I'm
not sure this is really the right place for it.

For me, the delegates belong to the chrome, so I would just add a Qt special
method for creating combos etc, like ::createSelectionPopup() or so. You could
make it Qt specific and do a cast to ChromeClientQt when creating the combos.

What do you think Simon?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.