[Webkit-unassigned] [Bug 20736] [GTK] GtkWebKit incompatible with rgba colormaps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 10:17:48 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=20736


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45297|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #13 from Gustavo Noronha (kov) <gns at gnome.org>  2009-12-29 10:17:47 PST ---
(From update of attachment 45297)
Wicked!

22         No new tests. (OOPS!)

We should explain here why this isn't testable right now.

5353 #include <string.h>
 54 #include <stdlib.h>

Poorly sorted

 108 static GHashTable *gPartsTable = NULL;
 109 static GtkThemeParts *gParts = NULL;

Bad placement for *'s

 227 gint
 228 moz_gtk_use_parts_for_drawable(GdkDrawable* parts);

gint should be in the same line, in the header file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list