[Webkit-unassigned] [Bug 20736] [GTK] GtkWebKit incompatible with rgba colormaps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 10:25:13 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=20736





--- Comment #14 from Martin Robinson <martin.james.robinson at gmail.com>  2009-12-29 10:25:12 PST ---
(In reply to comment #13)

> We should explain here why this isn't testable right now.
> Poorly sorted

Thanks for the review! I should have a fix for these first two issues soon.

>  108 static GHashTable *gPartsTable = NULL;
>  109 static GtkThemeParts *gParts = NULL;
> 
> Bad placement for *'s
> 
>  227 gint
>  228 moz_gtk_use_parts_for_drawable(GdkDrawable* parts);
> 
> gint should be in the same line, in the header file.

Since these files originate from Mozilla, I think using the original style in
this case will make it easier for the patch to move back upstream if there is
interest. I'm not sure if any resolution came from the discussion of this issue
on the mailing list.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list