[Webkit-unassigned] [Bug 32963] buildfix for ResourceHandleWin.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32963





--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-12-29 09:17:45 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 45527 [details] [details])
> > Please explain your changes in the ChangeLog.  There are too many, too
> > complicated changes for this to be reviewed with such an empty ChangeLog.
> This is _only_ a buildfix!

I believe you. :)  I just had trouble understanding the patch.  It's difficult
to tell if this change is only inside WINCE blocks.  I take it this code is not
used by the AppleWin port.  Is it used by the ChromiumWin port, or just the
WinCE port?  What about the CairoWin port?

See http://trac.webkit.org/changeset/43259 as an example of explaining
file-level changes in ChangeLogs.  The goal of the ChangeLog (in my mind) is to
document what the change is doing to make the review easier, and to make any
later "svn blame" investigation easier.
http://webkit.org/coding/contributing.html#changelogs has more thoughts on
ChangeLogs and their purpose.

In this case, I just don't have enough context to understand the change, but
it's possible that another reviewer would.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.