[Webkit-unassigned] [Bug 32963] buildfix for ResourceHandleWin.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32963





--- Comment #9 from Patrick R. Gansterer <paroga at paroga.com>  2009-12-29 08:43:38 PST ---
(In reply to comment #8)
> (From update of attachment 45527 [details])
> Please explain your changes in the ChangeLog.  There are too many, too
> complicated changes for this to be reviewed with such an empty ChangeLog.
This is _only_ a buildfix!

> For example, why this?
> -        if (method() == "POST") {
> +        if (request().httpMethod() == "POST") {
because http://trac.webkit.org/changeset/24202 removed the url(), postData()
and method() meberfunctions ;-)

> And this?
> +#ifdef RESOURCE_LOADER_DEBUG
> +        char buf[64];
> +        _snprintf(buf, sizeof(buf), "Load error: %i\n", error);
> +        OutputDebugStringA(buf);
> +#endif
_RPTF1 also outputs a debug string and isn't supported on WinCE

Maybe i can split it into a a windows and a wince part, but i don't think that
it make sense, because it doesn't work since r24204 and seams to be unuse. Real
enhancements will follow in a separate bug.

I think that the points mentioned in comment #3 are also reasons for r-, but i
like to get some howto feedback before i change it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.