[Webkit-unassigned] [Bug 32925] [Qt] Add Open File dialog to QtLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32925





--- Comment #9 from Ariya Hidayat <ariya.hidayat at gmail.com>  2009-12-29 09:14:01 PST ---
> > What about QLatin1String?
> 
> Is it better to use a QLatin1String over a QString? From the API for
> QFileDialog <http://doc.trolltech.com/4.6/qfiledialog.html> it is sufficient to
> pass a QString.

QLatin1String is good for a string constant, since it avoids a copy.
However, in the above case, it is supposed to be a null string, so just use
QString() as Simon suggested.

> 
> > 
> > Also, why are we using tr(), are we ever going to translate the launcher?
> 
> I can remove it if you want? For your reference, tr() appears at following
> places in the code:

My take: leave the tr as is, then we can have another patch that un-tr
everything (if needed).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.