[Webkit-unassigned] [Bug 32925] [Qt] Add Open File dialog to QtLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32925





--- Comment #8 from Daniel Bates <dbates at webkit.org>  2009-12-29 09:07:56 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 45480 [details] [details])
> > 
> > > +        QFileDialog fileDialog(this, tr("Open"), "", filter);
> > 
> > Please use QString() instead of "".
> 
> What about QLatin1String?

Is it better to use a QLatin1String over a QString? From the API for
QFileDialog <http://doc.trolltech.com/4.6/qfiledialog.html> it is sufficient to
pass a QString.

> 
> Also, why are we using tr(), are we ever going to translate the launcher?

I can remove it if you want? For your reference, tr() appears at following
places in the code:

Line 85:
<http://trac.webkit.org/browser/trunk/WebKitTools/QtLauncher/main.cpp?rev=52601#L85>
Line 520:
<http://trac.webkit.org/browser/trunk/WebKitTools/QtLauncher/main.cpp?rev=52601#L520>
Line 555:
<http://trac.webkit.org/browser/trunk/WebKitTools/QtLauncher/main.cpp?rev=52601#L555>
Line 582:
<http://trac.webkit.org/browser/trunk/WebKitTools/QtLauncher/main.cpp?rev=52601#L582>

We should probably adopt an all or nothing approach to internationalization of
QtLauncher. I think we should support possible "future" translations of the
app.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.