[Webkit-unassigned] [Bug 32797] [bzt] Optimize status updates for new dashboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32797





--- Comment #3 from Adam Barth <abarth at webkit.org>  2009-12-20 11:24:54 PST ---
> I'm surprised this isn't an error in python:

Oh, it probably does.  I wasn't posting it for review.  Hopefully the tests
will find these bugs though.  :)

> Personally I like storing state['patch'] in a local patch variable:

Ok.

> I'm not sure we should even output that much:
>  248         message = "Attachment %s did not pass %s:\n\n%s" %
> (state["patch"]["id"], cls.name,
> script_error.message_with_output(output_limit=3*1024))

Hum...  Pick a number.  :)

> The test seems kinda confusing... but OK.

Yeah, I thought of a better way to do this.  Basically, we want to make a
MockQueueEngine to do all the callbacks.  :)

Anyway, I've got to run.  Thanks for the comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.