[Webkit-unassigned] [Bug 32797] [bzt] Optimize status updates for new dashboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32797





--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-12-20 11:15:23 PST ---
(From update of attachment 45286)
I'm surprised this isn't an error in python:
 45             self._update_status("Building." % (patch["id"],
patch["bug_id"]), patch)

Personally I like storing state['patch'] in a local patch variable:
 74         message = "Attachment %s did not build on %s:\nBuild output: %s" %
(state["patch"]["id"], cls.port_name, results_link)

Again, should erorr:
 230         self._update_status("Checking style." % (patch["id"],
patch["bug_id"]), patch)

I'm not sure we should even output that much:
 248         message = "Attachment %s did not pass %s:\n\n%s" %
(state["patch"]["id"], cls.name,
script_error.message_with_output(output_limit=3*1024))

You could re-use an OutputCapture object:
 50         OutputCapture().assert_outputs(self, queue.queue_log_path,
expected_stdout=expected_stdout.get("queue_log_path", ""),
expected_stderr=expected_stderr.get("queue_log_path", ""))

The test seems kinda confusing... but OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.